Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better stream responses #28

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: better stream responses #28

wants to merge 6 commits into from

Conversation

oxidmod
Copy link

@oxidmod oxidmod commented Mar 9, 2023

  • Add new StreamResponse class to handle stream responses as generator or any other iterable values
  • Rework simple response handling to be the same as StreamResponse
  • Remove Server::push method as redundant

@oxidmod
Copy link
Author

oxidmod commented Mar 9, 2023 •
edited

todo:

  • update protoc plugin to generate correct services with stream response type

@oxidmod oxidmod marked this pull request as draft March 9, 2023 12:03
@doubaokun doubaokun force-pushed the master branch 6 times, most recently from fbf3590 to 7e034fd Compare March 22, 2023 17:37
@oxidmod oxidmod marked this pull request as ready for review March 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@oxidmod