Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relocate location of bootstrap.min.css loading #110

Merged
merged 1 commit into from May 12, 2022
Merged

relocate location of bootstrap.min.css loading #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions otcdocstheme/theme/otcdocs/css.html
View file
Open in desktop
@@ -1,6 +1,3 @@
<!-- Bootstrap CSS -->
<link href="{{pathto('_static/css/bootstrap.min.css', 1)}}" rel="stylesheet">

<!-- Fonts -->
<link href="{{pathto('_static/css/fontawesome-all.min.css', 1)}}" rel="stylesheet">
<link rel="preload" href="{{pathto('_static/webfonts/fa-regular-400.woff2', 1)}}" as="font" type="font/woff2" crossorigin>
Expand Down
2 changes: 2 additions & 0 deletions otcdocstheme/theme/otcdocs/static/css/otcdocstheme.css
View file
Open in desktop
@@ -1,3 +1,5 @@
@import "bootstrap.min.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you try to put it https://github.com/opentelekomcloud/otcdocstheme/blob/main/otcdocstheme/theme/otcdocs/theme.conf#L4 instead?

Copy link
Member Author

@tischrei tischrei May 12, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I can, but if I do it like this. The "default.css" is over otcdocstheme.css ;-). That makes no sense as well. I have opened an issue on: sphinx-doc/sphinx#10444

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side; I do not intend to keep it like this forever. But we need to have something like this to overcome the current issue. I am trying to invest some time in docsportal again, but I need this commit, first.


body {
--main-body-color: #hsl(0, 0%, 9.8%);
--bs-body-color: #hsl(0, 0%, 9.8%);
Expand Down