-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mle] implement alternate RLOC16 usage during role transition #10006
Open
abtink
wants to merge
1
commit into
openthread:main
Choose a base branch
from
abtink:mle/alt-short-addr
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abtink
added
enhancement
P4
api: platform
api: user
comp: rcp
comp: mle
comp: mac
labels
Apr 8, 2024
Size Report of OpenThread
|
abtink
force-pushed
the
mle/alt-short-addr
branch
from
April 9, 2024 21:43
ed9903a
to
da5a757
Compare
LuDuda
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! 👍
How do you plan to test this feature?
abtink
force-pushed
the
mle/alt-short-addr
branch
from
April 16, 2024 01:04
da5a757
to
765f64f
Compare
Thanks @LuDuda. I added a test that covers the basic behavior of this, i.e. the stack sets the "alt short address" after transition from child to router and after the timeout removes it. |
abtink
force-pushed
the
mle/alt-short-addr
branch
2 times, most recently
from
April 16, 2024 21:54
31024a4
to
a6e7b78
Compare
This commit introduces a mechanism for a device transitioning from child to router role to keep receiving frames addressed to its previous short address for a brief period. A new radio platform API, `otPlatRadioSetAlternateShortAddress()`, is introduced. This allows the OT stack to configure an alternate short address. Radio platform support for this function is indicated by the `OT_RADIO_CAPS_ALT_SHORT_ADDR` capability in `otPlatRadioGetCaps()` The same function can be used with `OT_RADIO_INVALID_SHORT_ADDR` (`0xfffe`) to clear a previously set alternate short address. Support for the new API is implemented in RCP and `RadioSpinel`, ensuring backward compatibility by dynamically checking supported radio capabilities. MLE code is updated to instruct the radio to use the old child RLOC16 as an alternate address upon role transition. The MLE layer will automatically clear the alternate address after eight seconds, or if other state/mode changes occur. This eight-second window ensures the new router can transmit four MLE Advertisement messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a mechanism for a device transitioning from child to router role to keep receiving frames addressed to its previous short address for a brief period.
A new radio platform API,
otPlatRadioSetAlternateShortAddress()
, is introduced. This allows the OT stack to configure an alternate short address. Radio platform support for this function is indicated by theOT_RADIO_CAPS_ALT_SHORT_ADDR
capability inotPlatRadioGetCaps()
The same function can be used withOT_RADIO_INVALID_SHORT_ADDR
(0xfffe
) to clear a previously set alternate short address. Support for the new API is implemented in RCP andRadioSpinel
, ensuring backward compatibility by dynamically checking supported radio capabilities.MLE code is updated to instruct the radio to use the old child RLOC16 as an alternate address upon role transition. The MLE layer will automatically clear the alternate address after eight seconds, or if other state/mode changes occur. This eight-second window ensures the new router can transmit four MLE Advertisement messages.
Rebased this PR on top of the commit from the following PR (used by the test).- #10033