[dnssd-server] implement DNS-SD discovery proxy functionality in core #10050
Conversation
Size Report of OpenThread
|
abtink
force-pushed
the
disc-proxy-new
branch
3 times, most recently
from
c09d867
to
8bf2e5e
Compare
include/openthread/mdns.h
Outdated
| * Refer to `otPlatDnssdAddressResolver` for documentation of member fields and `otMdnsStartIp6Resolver()` or | ||
| * `otMdnsStartIp4Resolver()` for how they are used. |
There was a problem hiding this comment.
otMdnsStartIp6Resolver --> otMdnsStartIp6AddressResolver
otMdnsStartIp4Resolver --> otMdnsStartIp4AddressResolver
There was a problem hiding this comment.
Fixed in new push. Thanks.
include/openthread/platform/dnssd.h
Outdated
| typedef struct otPlatDnssdBrowseResult otPlatDnssdBrowseResult; | ||
| typedef struct otPlatDnssdSrvResult otPlatDnssdSrvResult; | ||
| typedef struct otPlatDnssdTxtResult otPlatDnssdTxtResult; | ||
| typedef struct otPlatDnssdAddressResult otPlatDnssdAddressResult; |
There was a problem hiding this comment.
Documentation that you have for these below don't come through in Doxygen when they are typedef'd up here:
I assume you've done this for a reason... can the documentation comment for each also be put up here?
There was a problem hiding this comment.
In the new push, I've re-arranged the type definitions and removed these.
These were intended as forward declarations so we can define the types in a more intuitive sequence. The challenge is that the Browser/Resolver types reference their corresponding Callback types, which in turn reference the Result type. We now define Result first, followed by Callback, and finally the Browser/Resolver structures.
There was a problem hiding this comment.
Thanks for rearranging, everything comes through now 👍
|
Hi @abtink, the name of the commit has changed to "[mle] allow appending pending timestamp TLV with zero seconds" I guess it was by mistake and you just did a rebase of the branch. On the other hand, is there anything else missing to merge this PR? It looks like it has all the approvals. |
This commit implements a generic discovery proxy in the DNS-SD server. It uses a set of newly added `otPlatDnssd` platform DNS-SD(mDNS) APIs to start or stop browsers, SRV/TXT resolvers, and IPv6/IPv4 address resolvers. These APIs closely match the native OpenThread mDNS implementation. OpenThread DNS-SD's existing `QueryCallback` mechanism, enabling customized discovery proxy implementations, remains supported. This commit includes a comprehensive unit test. This test validates the discovery proxy's behavior, covering: standard use cases, request timeout, s hared resolver/browser usage for multiple queries with the same name, filtering of invalid addresses, and various edge cases.
Thanks @marius-preda for noticing the commit message change. I am not sure how it happened. I just rebased it recently. It is interesting that it was changed to |
This commit implements a generic discovery proxy in the DNS-SD server. It uses a set of newly added
otPlatDnssdplatform DNS-SD(mDNS) APIs to start or stop browsers, SRV/TXT resolvers, and IPv6/IPv4 address resolvers. These APIs closely match the native OpenThread mDNS implementation.OpenThread DNS-SD's existing
QueryCallbackmechanism, enabling customized discovery proxy implementations, remains supported.This commit includes a comprehensive unit test. This test validates the discovery proxy's behavior, covering: standard use cases, request timeout, s hared resolver/browser usage for multiple queries with the same name, filtering of invalid addresses, and various edge cases.