-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[github-actions] limit "upload coverage" job to openthread repo #10136
base: main
Are you sure you want to change the base?
Conversation
Size Report of OpenThread
|
.github/workflows/otbr.yml
Outdated
@@ -233,6 +233,7 @@ jobs: | |||
retention-days: 1 | |||
|
|||
upload-coverage: | |||
if: github.event.pull_request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to upload coverage on pushes to main branch. Can we instead limit to the specific github repo?
github.repository == 'openthread/openthread'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in new push to use this condition.
This commit updates the GitHub Action workflows to skip the "upload-coverage" job on when target repo is a fork of openthread.
58e338c
to
537df8a
Compare
It seems the code coverage report has been missing for a while. Is this PR fixing the issue? |
No, not directly. Though it might help indirectly. It prevents the "update coverage" step from running on forks of the OT repo, limiting it to the main repo. This should reduce traffic to the underlying Coverity server, which could potentially improve its performance and responsiveness. |
It appears Codecov has errors processing coverage reports. For example: |
This commit updates the GitHub Action workflows to skip the "upload-coverage" job when target repo is a fork of openthread.