Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[routing-manager] move tracking of local RA header to RxRaTracker #10257

Merged
merged 1 commit into from
May 17, 2024

Conversation

abtink
Copy link
Member

@abtink abtink commented May 16, 2024

This commit moves the tracking of the RA header of locally generated RA messages from TxRaInfo to the RxRaTracker class. The tracked RA header is used when RoutingManager sends an RA, ensuring consistent RA headers across all RAs emitted from the device.

This aligns the logic by having RxRaTracker track all information from received RAs and simplifies stale time calculations.


This PR contains the commit from #10255. Please check and review the last commit. Thanks.

Copy link

size-report bot commented May 16, 2024

Size Report of OpenThread

Merging #10257 into main(213aede).

name branch text data bss total
ot-cli-ftd main 467040 856 66364 534260
#10257 467040 856 66364 534260
+/- 0 0 0 0
ot-ncp-ftd main 435884 760 61576 498220
#10257 435884 760 61576 498220
+/- 0 0 0 0
libopenthread-ftd.a main 236166 95 40310 276571
#10257 236166 95 40310 276571
+/- 0 0 0 0
libopenthread-cli-ftd.a main 57533 0 8075 65608
#10257 57533 0 8075 65608
+/- 0 0 0 0
libopenthread-ncp-ftd.a main 31863 0 5916 37779
#10257 31863 0 5916 37779
+/- 0 0 0 0
ot-cli-mtd main 364520 760 51220 416500
#10257 364520 760 51220 416500
+/- 0 0 0 0
ot-ncp-mtd main 347044 760 46448 394252
#10257 347044 760 46448 394252
+/- 0 0 0 0
libopenthread-mtd.a main 158165 0 25182 183347
#10257 158165 0 25182 183347
+/- 0 0 0 0
libopenthread-cli-mtd.a main 39756 0 8059 47815
#10257 39756 0 8059 47815
+/- 0 0 0 0
libopenthread-ncp-mtd.a main 24743 0 5916 30659
#10257 24743 0 5916 30659
+/- 0 0 0 0
ot-cli-ftd-br main 550768 864 131204 682836
#10257 550688 864 131204 682756
+/- -80 0 0 -80
libopenthread-ftd-br.a main 324592 100 105126 429818
#10257 324624 100 105126 429850
+/- +32 0 0 +32
libopenthread-cli-ftd-br.a main 71320 0 8099 79419
#10257 71320 0 8099 79419
+/- 0 0 0 0
ot-rcp main 62216 564 20604 83384
#10257 62216 564 20604 83384
+/- 0 0 0 0
libopenthread-rcp.a main 9542 0 5052 14594
#10257 9542 0 5052 14594
+/- 0 0 0 0
libopenthread-radio.a main 18870 0 214 19084
#10257 18870 0 214 19084
+/- 0 0 0 0

This commit moves the tracking of the RA header of locally generated
RA messages from `TxRaInfo` to the `RxRaTracker` class. The tracked
RA header is used when `RoutingManager` sends an RA, ensuring
consistent RA headers across all RAs emitted from the device.

This aligns the logic by having `RxRaTracker` track all information
from received RAs and simplifies stale time calculations.
@abtink abtink force-pushed the rm/tx-ra-header-from-other-entity branch from 33e5ec4 to 2d6c9d1 Compare May 17, 2024 15:59
@abtink abtink marked this pull request as ready for review May 17, 2024 16:01
@jwhui jwhui merged commit 67a2627 into openthread:main May 17, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants