[utils] fix build when OPENTHREAD_CONFIG_CHANNEL_MONITOR_ENABLE=0
#10260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NFIG_CHANNEL_MONITOR_ENABLE [Issue] Disabling channel monitor feature on ot-daemon by setting following flag "OT_CHANNEL_MONITOR = 0" a compilation error was present. [Fix] Some pieces of code in OpenThread shall be under OPENTHREAD_CONFIG_CHANNEL_MONITOR_ENABLE. Signed-off-by: Ashishkumar Vara <ashish.vara@nxp.com>
Size Report of OpenThread
|
abtink
reviewed
May 17, 2024
There was a problem hiding this comment.
Thanks @aashu216.
I am fine merging this PR to fix the build errors.
However, looking at the code, I see many methods that could be better guarded and only provided when CHANNEL_MONITOR is enabled. The addition of CSL channel changes has increased the complexity of the entire module. Fixing this properly will require a larger change. I can try to address this later when I have the opportunity.
| @@ -423,12 +425,14 @@ void ChannelManager::StartAutoSelectTimer(void) | |||
| #if OPENTHREAD_FTD | |||
| void ChannelManager::SetAutoNetworkChannelSelectionEnabled(bool aEnabled) | |||
| { | |||
| #if OPENTHREAD_CONFIG_CHANNEL_MONITOR_ENABLE | |||
There was a problem hiding this comment.
I think we should guard this whole method with CHANNEL_MONITOR_ENABLE. Auto-selection mode only make sense when "channel-moinitor" feature is enabled
There was a problem hiding this comment.
Thanks @abtink, yes it needs large changes if we want to guard this method. Can you please help merge with this PR to fix build issue as of now?
abtink
approved these changes
May 20, 2024
jwhui
changed the title
OPENTHREAD_CONFIG_CHANNEL_MONITOR_ENABLE=0
jwhui
approved these changes
May 20, 2024
jwhui
changed the title
OPENTHREAD_CONFIG_CHANNEL_MONITOR_ENABLE=0OPENTHREAD_CONFIG_CHANNEL_MONITOR_ENABLE=0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Issue] Disabling channel monitor feature on ot-daemon by setting following flag "OT_CHANNEL_MONITOR = 0" a compilation error was present.
[Fix] Some pieces of code in OpenThread shall be under OPENTHREAD_CONFIG_CHANNEL_MONITOR_ENABLE.