[mdns] ensure callback is invoked when registering host with no address #10264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the native mDNS implementation to ensure the callback is invoked when a host is registered without any address (effectively unregistering the host and removing any previously registered addresses for the host-name). The implementation ensures the callback is invoked after returning from the `RegisterHost()` call (invoked from a posted tasklet), as required by the mDNS API definitions. Additionally, the `test_mdns` unit test is updated to cover registering a host with no address for the first time or updating a previous registration.
Size Report of OpenThread
|
|
@Cristib05 , can you help indicate whether this PR addresses your issue? |
Thanks @abtink for implementing this PR! It does address the reported issue; the SRP Update is accepted without any other retries from the client (as described in the opened issue). |
jwhui
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the native mDNS implementation to ensure the callback is invoked when a host is registered without any address (effectively unregistering the host and removing any previously registered addresses for the host-name).
The implementation ensures the callback is invoked after returning from the
RegisterHost()call (invoked from a posted tasklet), as required by the mDNS API definitions.Additionally, the
test_mdnsunit test is updated to cover registering a host with no address for the first time or updating a previous registration.Fixes #10262