-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tcat] implement tcat advertisement #9858
Conversation
@EskoDijk @arnulfrupp FYI |
Size Report of OpenThread
|
f1f37a8
to
8f6d29a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9858 +/- ##
===========================================
+ Coverage 64.92% 82.77% +17.84%
===========================================
Files 505 560 +55
Lines 61703 72098 +10395
===========================================
+ Hits 40062 59678 +19616
+ Misses 21641 12420 -9221
|
69af197
to
fe8103f
Compare
627aaa6
to
8597c53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @canisLupus1313. Looks good overall.
Some smaller suggestions below.
7b25679
to
292d6d5
Compare
@EskoDijk @arnulfrupp any more comments from Your site? |
71cd7b7
to
fa351ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @canisLupus1313.
Some smaller suggestion below.
@canisLupus1313 Not for now - maybe I can propose further changes (if needed) in a later PR or issue. It's easier to see what's needed after some test runs (either in simulation or on the testbed). |
a47ca03
to
6c6d653
Compare
@EskoDijk |
4be06c5
to
db8a1bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok (I didn't review all details)
db8a1bf
to
59b1187
Compare
Commit introduces implementation of TCAT advertisement over BLE compialnt with Thread 1.3.1 specification.
59b1187
to
202fbf6
Compare
Commit introduces implementation of TCAT advertisement over BLE compialnt with Thread 1.3.1 specification.