0.17.2 to main (#510)

* fix: incorrect audio bitrate sanitization * fix: audio crash on teardown * kick off co * Update OTCustomAudioDriver.swift * ignore: CI * ignore: CI * update package and changelog Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com> Co-authored-by: Mario Scheliga <mscheliga@linkando.com>
opentok · May 28, 2021 · fcbf1c2 · fcbf1c2
1 parent 771fb6f
commit fcbf1c2
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.17.2 (May 27, 2021)
+- **[Fix]**: Fixed incorrect audio bitrate sanitization [#473](https://github.com/opentok/opentok-react-native/pull/473)
+- **[Fix]**: Fix audio crash on teardown [#495](https://github.com/opentok/opentok-react-native/pull/495)
+
 # 0.17.1 (May 25, 2021)
 
 - **[Fix]**: Fixed @opentok/types (merged from [PR505](https://github.com/opentok/opentok-react-native/pull/505))

diff --git a/ios/OpenTokReactNative/OTCustomAudioDriver.swift b/ios/OpenTokReactNative/OTCustomAudioDriver.swift
@@ -354,10 +354,12 @@ extension OTCustomAudioDriver: OTAudioDevice {
 
         playing = false
 
-        let result = AudioOutputUnitStop(playoutVoiceUnit!)
-        if result != noErr {
-            print("Error creaing playout unit")
-            return false
+        if playoutVoiceUnit != nil {
+            let result = AudioOutputUnitStop(playoutVoiceUnit!)
+            if result != noErr {
+                print("Error creaing playout unit")
+                return false
+            }
         }
 
         if !recording && !isPlayerInterrupted && !isResetting {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "opentok-react-native",
-  "version": "0.17.1",
+  "version": "0.17.2",
   "description": "React Native components for OpenTok iOS and Android SDKs",
   "main": "src/index.js",
   "homepage": "https://www.tokbox.com",

diff --git a/src/helpers/OTPublisherHelper.js b/src/helpers/OTPublisherHelper.js
@@ -31,7 +31,7 @@ const sanitizeCameraPosition = (cameraPosition = 'front') => (cameraPosition ===
 const sanitizeVideoSource = (videoSource = 'camera') => (videoSource === 'camera' ? 'camera' : 'screen');
 
 const sanitizeAudioBitrate = (audioBitrate = 40000) =>
-  (audioBitrate < 80000 || audioBitrate > 128000 ? 40000 : audioBitrate);
+  (audioBitrate < 6000 || audioBitrate > 510000 ? 40000 : audioBitrate);
 
 const sanitizeProperties = (properties) => {
   if (typeof properties !== 'object') {