Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi Thread Perf Tests #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lappazos
Copy link
Contributor

What

Add a multithreaded option to perf test

Why ?

Add option to check mt performance

How ?

Change infrastructure of perf tests

@lappazos
Copy link
Contributor Author

code from #215

Copy link
Contributor

@Sergei-Lebedev Sergei-Lebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, pls fix minor codestyle comments

test_args_t test_args;
int i, n_threads = config.n_threads;
std::vector<pthread_t> threads;
threads.resize(n_threads);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::vector<pthread_t> threads(n_threads);

int i, n_threads = config.n_threads;
std::vector<pthread_t> threads;
threads.resize(n_threads);
std::vector<thread_args_t> threads_args;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::vector<thread_args_t> threads_args(n_threads);

@manjugv
Copy link
Contributor

manjugv commented Feb 2, 2022

WG Discussion: @vspetrov to review and revive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants