TL/MLX5: fix IPv6 address conversion in inet_ntop #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hi @miharulidze, thanks for the PR, do you have contributor agreement signed of? |
|
@Sergei-Lebedev nope - but can do within the week. Should I ack you when it's done? |
Yes, please. We need CLA to merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This commit fixes the conversion of binary IPv6 address into the human-readable string using
inet_ntop.Why ?
In our testing environment, the debug output of MLX5 TL prints garbage IPv6 addresses during the multicast initialization/teardown phase.
How ?
Pass
sin6_addrfield of typestruct in6_addrthat is the part of thesockaddr_in6structure, as specified in https://man7.org/linux/man-pages/man3/inet_ntop.3.html