Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test option to package add #9

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Added Test option to package add #9

merged 5 commits into from
Jun 18, 2020

Conversation

Bullrich
Copy link
Contributor

Added the option -t and --testables to add the package name to the testables array.

Copy link
Member

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. See the comments below.

README.md Outdated Show resolved Hide resolved
lib/cli.js Outdated Show resolved Hide resolved
lib/core.js Outdated Show resolved Hide resolved
@Bullrich Bullrich requested a review from favoyang June 17, 2020 15:12
@Bullrich
Copy link
Contributor Author

Thanks for looking at my PR. I changed the things that you requested and don't know if there is anything it can be done about the env.testables parameter

@favoyang
Copy link
Member

Thanks for looking at my PR. I changed the things that you requested and don't know if there is anything it can be done about the env.testables parameter

Thanks for the quick fix! My comment is in #9 (comment)

@Bullrich
Copy link
Contributor Author

I copied the implementation from the deep function.

Using object destructuring should bring a similar approach. Could you give it a second look please? I don't want to mess with the parameter's object and break the implementation.

Copy link
Member

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@favoyang favoyang merged commit 6ef13ee into openupm:master Jun 18, 2020
favoyang added a commit that referenced this pull request Jun 18, 2020
github-actions bot pushed a commit that referenced this pull request Jun 18, 2020
# [1.8.0](1.7.1...1.8.0) (2020-06-18)

### Features

* add test option to the add command ([#9](#9)) ([9f976bd](9f976bd))
@github-actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Bullrich Bullrich deleted the test-option branch June 18, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants