Improving parser for 'crossroad_camera_demo' #3359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins please retry a build |
5 similar comments
|
Jenkins please retry a build |
|
Jenkins please retry a build |
|
Jenkins please retry a build |
|
Jenkins please retry a build |
|
Jenkins please retry a build |
ieliz
force-pushed
the
ei/crossroad_parser
branch
from
893cf64
to
85a313b
Compare
Wovchena
requested changes
Mar 31, 2022
| << "\n\t[--show] ([--noshow]) " << show_msg | ||
| << "\n\t[ -t <NUMBER>] " << t_msg | ||
| << "\n\t[--tpr <NUMBER>] " << tpr_msg | ||
| << "\n\t[ -u <MONITORS>] " << u_msg |
There was a problem hiding this comment.
Suggested change
| << "\n\t[ -u <MONITORS>] " << u_msg | |
| << "\n\t[ -u <MONITORS>] " << u_msg |
| } | ||
| videoWriter.write(frame); | ||
| if (FLAGS_show) { | ||
| cv::imshow("Detection results", frame); |
There was a problem hiding this comment.
Suggested change
| cv::imshow("Detection results", frame); | |
| cv::imshow(argv[0], frame); |
| videoWriter.write(frame); | ||
| if (FLAGS_show) { | ||
| cv::imshow("Detection results", frame); | ||
| const int key = cv::waitKey(1); |
There was a problem hiding this comment.
Suggested change
| const int key = cv::waitKey(1); | |
| const int key = cv::pollKey(); |
| if (FLAGS_show) { | ||
| cv::imshow("Detection results", frame); | ||
| const int key = cv::waitKey(1); | ||
| if (27 == key) // Esc |
There was a problem hiding this comment.
Add Q and q in addition to Esc
Handle pause keys
Comment on lines
73
to
74
| "(as it is returned from the detection network, may vary from one network to another). " | ||
| "Default is 1"; |
There was a problem hiding this comment.
Suggested change
| "(as it is returned from the detection network, may vary from one network to another). " | |
| "Default is 1"; | |
| "(as it is returned from the detection network, may vary from one network to another). " | |
| "Default is 1"; |
| DEFINE_double(tpr, 0.7, tpr_msg); | ||
|
|
||
| constexpr char u_msg[] = "resource utilization graphs. " | ||
| "c - average CPU load, d - load distribution over cores, m - memory usage, h - hide"; |
There was a problem hiding this comment.
Suggested change
| "c - average CPU load, d - load distribution over cores, m - memory usage, h - hide"; | |
| "c - average CPU load, d - load distribution over cores, m - memory usage, h - hide"; |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing parser for 'crossroad_camera_demo'.
Aligning code style of parser according to OMZ. requirements(indentations, the naming of arguments, etc).
Changing test cases and README.md.
As example used PR: #3131