modemmanager: do not disable modem on reconnect #24184
Draft
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the modem loses the connection, an attempt is made to re-establish the connection via the report-down script. Until now, the modem was disabled when the modem processed the teardown of the modemmanager protohandler. The immediate up events of netifd renables the modem right away. This takes time, which is not necessary. This commit changes the behavior so that the modem is not disabled when the modemmanager is disconnected via the report-down script. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
lynxthecat
reviewed
May 17, 2024
| # The modem therefore does not need to be disabled. | ||
| local disable="$(uci_get_state network "$interface" disable_modem "1")" | ||
| if [ "${disable}" -eq 0 ]; then | ||
| echo "Modem remains enabled" |
There was a problem hiding this comment.
Might something like: "Skipping modem disable" be more informative?
|
@feckert nicely done! This looks good to me, but I am hopeful that we can get input from others more experienced with the mechanics of netifd and ModemManager than I. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If the modem loses the connection, an attempt is made to re-establish the connection via the report-down script.
Until now, the modem was disabled when the modem processed the teardown of the modemmanager protohandler. The immediate up events of netifd renables the modem right away. This takes time, which is not necessary.
This commit changes the behavior so that the modem is not disabled when the modemmanager is disconnected via the report-down script.
Maintainer: me / @<github-user> (find it by checking history of the package Makefile)
Compile tested: (put here arch, model, OpenWrt version)
Run tested: (put here arch, model, OpenWrt version, tests done)