add options to configure logger by interface #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kujenga thanks for coming by. I could not see the logger interface, did you forget to include it? |
kujenga
force-pushed
the
at/log-interface
branch
from
a8f3664
to
8430ce5
Compare
1 similar comment
This commit provides users of this library with the ability to configure any logger of their choosing to be passed into the various components of this library. Doing so allows use cases such as using other open source logging packages, e.g. logrus or zap, in conjunction with this library. Closes openzipkin#37
kujenga
force-pushed
the
at/log-interface
branch
from
8430ce5
to
0ed0638
Compare
|
Ah, thank you @jcchavezs ! I created a new file for it and missed it in my commit 🙈 all fixed now! |
|
Sorry guys, any update on this? Can I help? @kujenga @jcchavezs |
|
@jcchavezs if there is anything else needed from here here let me know! would be great to get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides users of this library with the ability to configure
any logger of their choosing to be passed into the various components of
this library. Doing so allows use cases such as using other open source
logging packages, e.g. logrus or zap, in conjunction with this library.
Closes #37