Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add noopdelete option to extension api #772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gallettilance
Copy link
Member

Description

Solves #723

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@gallettilance gallettilance requested a review from a team as a code owner April 22, 2024 13:32
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d057713
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/662bca56bb76fd0008ea6abe
😎 Deploy Preview https://deploy-preview-772--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
@@ -432,6 +432,10 @@ func (r *ExtensionReconciler) GenerateExpectedApp(o ocv1alpha1.Extension, bundle
},
}

if o.Spec.NoopDelete {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a conditional here, right?

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.12%. Comparing base (9785be8) to head (2276f78).
Report is 7 commits behind head on main.

Files Patch % Lines
internal/controllers/extension_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   67.90%   67.12%   -0.79%     
==========================================
  Files          22       22              
  Lines        1424     1466      +42     
==========================================
+ Hits          967      984      +17     
- Misses        391      416      +25     
  Partials       66       66              
Flag Coverage Δ
e2e 45.42% <0.00%> (-0.92%) ⬇️
unit 61.30% <0.00%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn changed the title Add noopdelete option to extension api ✨ Add noopdelete option to extension api Apr 22, 2024
@grokspawn
Copy link
Contributor

I ✨ the PR title to pass the pr-title workflow, based on PR contents. This repo enforces naming along these lines:
* ⚠ (:warning:, major/breaking change)
* ✨ (:sparkles:, minor/compatible change)
* 🐛 (:bug:, patch/bug fix)
* 📖 (:book:, docs)
* 🌱 (:seedling:, other)

If that's not correct, please choose the option that best fits.

@tmshort
Copy link
Contributor

tmshort commented Apr 22, 2024

make verify needs to be run before commiting.

@joelanford
Copy link
Member

I'm curious if there's a reason we're adding a new feature to the extension API, given that we're planning to focus on the cluster extension API and temporarily remove this API.

Should we just make this change directly on the ClusterExtension instead?

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! /lgtm from my end, after addressing Joe's review.

Regarding surfacing this on the status - looking deeper, it doesn't seem necessary imo. We don't specify anything explicitly for paused state either. Also this info may be useful only when the user tries to delete the relevant extension, at which point we are not going to persist the object itself. Just cross-checked, looks like PackageInstall doesn't have it too.

api/v1alpha1/extension_types.go Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants