✨ Add optional field to ClusterExtension API to skip CRD upgrade safety checks #845
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rashmigottipati
force-pushed
the
configure-crd-checks
branch
from
63d53f0
to
580c351
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 71.02% 70.05% -0.97%
==========================================
Files 17 17
Lines 1301 1319 +18
==========================================
Hits 924 924
- Misses 304 322 +18
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rashmigottipati
force-pushed
the
configure-crd-checks
branch
2 times, most recently
from
96a459e
to
e35ad16
Compare
rashmigottipati
force-pushed
the
configure-crd-checks
branch
from
c4dd907
to
224d139
Compare
… checks Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
rashmigottipati
force-pushed
the
configure-crd-checks
branch
from
224d139
to
fffc98a
Compare
| //+kubebuilder:validation:Enum:=Enabled;Disabled | ||
| //+kubebuilder:default:=Enabled | ||
| //+kubebuilder:Optional | ||
| CRDUpgradeSafetyMode CRDUpgradeSafetyMode `json:"mode,omitempty"` |
There was a problem hiding this comment.
nit:
Suggested change
| CRDUpgradeSafetyMode CRDUpgradeSafetyMode `json:"mode,omitempty"` | |
| Mode CRDUpgradeSafetyMode `json:"mode,omitempty"` |
everettraven
approved these changes
May 14, 2024
There was a problem hiding this comment.
One minor nit, but not worth blocking this PR from merging IMO. Thanks @rashmigottipati !
joelanford
reviewed
May 14, 2024
|
|
||
| //+kubebuilder:Optional | ||
| // Preflight defines the strategy for the preflight checks (i.e. as of now, the CRD upgrade safety checks) to be applied or skipped when attempting to install the cluster extension. | ||
| Preflight PreflightConfig `json:"preflight,omitempty"` |
There was a problem hiding this comment.
If a field is optional (i.e. with omitempty), it should also be a pointer.
There was a problem hiding this comment.
Ah good catch - I totally missed that!
joelanford
reviewed
May 14, 2024
| // PreflightConfig holds the config for the preflight checks. Currently, this is implemented for the | ||
| // CRDUpgradeSafety preflight check and can be extended in the future to add other preflight checks. | ||
| type PreflightConfig struct { | ||
| CRDUpgradeSafety CRDUpgradeSafetyPreflightConfig `json:"crdUpgradeSafety,omitempty"` |
There was a problem hiding this comment.
Same comment as above: re using pointer if field is optional.
|
Please hold this from merging till #846 gets in. Thanks! |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional ClusterExtension.spec.skipCRDUpgradeSafetyChecks field that when set to true will be used to disable the CRD upgrade safety checks when attempting to install a cluster extension.
No logic included in this PR as the CRD Upgrade Safety preflight check as there isn't anything yet to enable/disable. So logic to enable/disable will be added in a future PR once everything is in place.
fixes #745
Reviewer Checklist