🌱 Helm POC e2e fixes #870

dtfranz · 2024-05-17T00:10:41Z

Fixes the e2e tests in helm-poc branch.

internal/catalogmetadata/filter/bundle_predicates.go

internal/controllers/clusterextension_controller.go

test/e2e/cluster_extension_install_test.go

test/e2e/cluster_extension_registryV1_limitations_test.go

codecov · 2024-05-17T17:57:47Z

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.38%. Comparing base (570b89f) to head (f31a99d).

Files	Patch %	Lines
...nternal/controllers/clusterextension_controller.go	77.14%	5 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           helm-poc     #870      +/-   ##
============================================
+ Coverage     74.87%   75.38%   +0.51%     
============================================
  Files            18       18              
  Lines          1158     1170      +12     
============================================
+ Hits            867      882      +15     
+ Misses          211      208       -3     
  Partials         80       80

Flag	Coverage Δ
e2e	`56.06% <73.68%> (+3.65%)`	⬆️
unit	`50.60% <34.21%> (-0.42%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

varshaprasad96 · 2024-05-17T18:27:22Z

@dtfranz Great work!! all e2e are passing 🎉 !

Fixes the e2e tests in helm-poc branch. Signed-off-by: dtfranz <dfranz@redhat.com>

Fixes the e2e tests in helm-poc branch and restores feature-gate switching. Signed-off-by: dtfranz <dfranz@redhat.com>

…s into the cluster (#846) * Helm POC rebase-a-thon * Unpack Image (#811) Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com> * ✨ OPRUN-3293 Fixes several unit tests - not cache ones (#831) * Fix, rm or skip BundleDeployment related tests Signed-off-by: Brett Tofel <btofel@redhat.com> * Address lint errors Signed-off-by: Brett Tofel <btofel@redhat.com> --------- Signed-off-by: Brett Tofel <btofel@redhat.com> * Fix e2e (#843) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Make goreleaser build unpack Signed-off-by: Brett Tofel <btofel@redhat.com> * Rm commented code Signed-off-by: Brett Tofel <btofel@redhat.com> * Rebase required changes Signed-off-by: Brett Tofel <btofel@redhat.com> * Cleanups (#854) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Expand comments in Dockerfile Signed-off-by: Brett Tofel <btofel@redhat.com> * Address Reviews Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Back out packagerrors It's agreed that this makes debugging and reasoning about log messages and runtime errors much harder. Signed-off-by: Brett Tofel <btofel@redhat.com> * Helm POC e2e fixes (#870) Fixes the e2e tests in helm-poc branch and restores feature-gate switching. Signed-off-by: dtfranz <dfranz@redhat.com> * Fix defer location (#883) Fixes the defer location to make sure that all resources are cleaned up properly. Signed-off-by: dtfranz <dfranz@redhat.com> * Remove BundleDeployments gathering from e2e's gatherArtifacts (#886) When tests fail, gatherArtifacts is run to collect cluster state. This PR removes gathering of BundleDeployments since we don't use them anymore and it's generating additional misleading error messages. Signed-off-by: dtfranz <dfranz@redhat.com> * Address reviews (#887) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * 🌱 Proposed way to unskip some tests (#874) * Proposed way to unskip some tests TestClusterExtensionChannelVersionExists mostly restored here Signed-off-by: Brett Tofel <btofel@redhat.com> * Refactors global variable names Signed-off-by: Brett Tofel <btofel@redhat.com> * Removes BundleDeployment related checking In just one test, for now. Signed-off-by: Brett Tofel <btofel@redhat.com> * fix unit test - TestClusterExtensionChannelVersionExists * Unskip all - failing tests (up|down)grade should err Unskips all in clusterextension_controller_test.go Signed-off-by: Brett Tofel <btofel@redhat.com> * Unskip all clusterextension_registryv1_validation_test.go Still failing tests (up|down)grade should err b/c we don't have an installedBundle to check against Signed-off-by: Brett Tofel <btofel@redhat.com> * debugging Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Fixes and additions pending & unpack path Signed-off-by: Brett Tofel <btofel@redhat.com> * Fix linter, remove debug logs and extraneous file Signed-off-by: dtfranz <dfranz@redhat.com> * Fix e2e failure due to race condition Signed-off-by: dtfranz <dfranz@redhat.com> --------- Signed-off-by: Brett Tofel <btofel@redhat.com> Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Signed-off-by: dtfranz <dfranz@redhat.com> Co-authored-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Co-authored-by: dtfranz <dfranz@redhat.com> * Revert goreleaser to use buildx Signed-off-by: Brett Tofel <btofel@redhat.com> * Revert all of goreleaser to use buildx Signed-off-by: Brett Tofel <btofel@redhat.com> * Revert errorf->printf & rm some logging in tests Signed-off-by: Brett Tofel <btofel@redhat.com> --------- Signed-off-by: dtfranz <dfranz@redhat.com> Signed-off-by: Brett Tofel <btofel@redhat.com> Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Co-authored-by: Todd Short <tshort@redhat.com> Co-authored-by: Daniel Franz <dfranz@redhat.com> Co-authored-by: Varsha <varshaprasad96@gmail.com>

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024