Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump k8s.io/api to v0.30.0 sigs.k8s.io/controller-runtime to v0.18.0 sigs.k8s.io/controller-tools to 0.15.0 + codegen refactor #3240

Merged
merged 5 commits into from
May 17, 2024
Merged

build(deps): bump k8s.io/api to v0.30.0 sigs.k8s.io/controller-runtime to v0.18.0 sigs.k8s.io/controller-tools to 0.15.0 + codegen refactor #3240

merged 5 commits into from
May 17, 2024

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 9, 2024 •
edited

Description of the change:
The scripts we were using to generate client code were deprecated and with the new version of kube they were removed breaking codegen. This PR bumps kube to v0.30.0, controller-runtime to v0.18.0, and updates the code generation to use the new scrips.

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@perdasilva perdasilva mentioned this pull request May 9, 2024
Closed
@perdasilva perdasilva force-pushed the refactor/codegen branch 4 times, most recently from d7a4feb to cc9af38 Compare May 10, 2024 10:20
@perdasilva perdasilva changed the title cleanup: update kube libs to v0.30.0 and refactor codegeneration for the update build(deps): bump k8s.io/api to v0.30.0 sigs.k8s.io/controller-runtime to v0.18.0 + codegen refactor May 10, 2024
@perdasilva perdasilva force-pushed the refactor/codegen branch 4 times, most recently from 3375367 to 4deb8b8 Compare May 10, 2024 12:16
@perdasilva
Copy link
Collaborator Author

/hold waiting for consensus before merging

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
This was referenced May 14, 2024
Closed
Closed
Closed
@perdasilva perdasilva changed the title build(deps): bump k8s.io/api to v0.30.0 sigs.k8s.io/controller-runtime to v0.18.0 + codegen refactor build(deps): bump k8s.io/api to v0.30.0 sigs.k8s.io/controller-runtime to v0.18.0 sigs.k8s.io/controller-tools to 0.15.0 + codegen refactor May 14, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@perdasilva
Copy link
Collaborator Author

Might as well update api and operator-registry to their 0.30.0 versions

Per Goncalves da Silva added 5 commits May 17, 2024 09:33
bump kube api to 0.30.0
af6edf4 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
bump controller-runtime to v0.18.0
fd66254 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
update codegen script
a0f0fd4 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
update generated code
4abdf58 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
bump controller-tools to v0.15.0
ad98d7d 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva mentioned this pull request May 17, 2024
Closed
11 tasks
@perdasilva
Copy link
Collaborator Author

/unhold release released

@perdasilva perdasilva removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@kevinrizza kevinrizza added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@perdasilva perdasilva added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@perdasilva perdasilva added this pull request to the merge queue May 17, 2024
Merged via the queue into operator-framework:master with commit d15a4b5 May 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrizza kevinrizza kevinrizza approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@benluddy benluddy Awaiting requested review from benluddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perdasilva @kevinrizza @openshift-merge-robot