Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leader and status which have moved to operator-lib. #3503

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Remove leader and status which have moved to operator-lib. #3503

merged 1 commit into from
Jul 24, 2020

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Jul 23, 2020

Description of the change:
Removed pkg/leader and pkg/status. Ansible (#3457) and Helm (#3446) operators were switched to use controller-runtime's leader election.

Motivation for the change:
pkg/leader and pkg/status were moved to operator-lib

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@joelanford joelanford mentioned this pull request Jul 23, 2020
Closed
92 tasks
joelanford
joelanford approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
estroz
estroz approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri merged commit 35934ad into operator-framework:master Jul 24, 2020
@jmrodri jmrodri deleted the remove-items-moved-to-operator-lib branch August 17, 2020 15:46
@yashgiri yashgiri mentioned this pull request Sep 29, 2020
Closed
@imilchev imilchev mentioned this pull request Oct 29, 2020
Closed
@janisz janisz mentioned this pull request Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@estroz estroz estroz approved these changes

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@joelanford joelanford

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmrodri @joelanford @estroz @openshift-ci-robot