Bugfix: Ansible operator: add finalizers permission for created APIs #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
force-pushed
the
add-role
branch
from
19d5266
to
6b1b9be
Compare
joelanford
requested changes
Aug 24, 2020
internal/plugins/ansible/v1/scaffolds/internal/templates/config/rbac/role.go
Outdated
Show resolved
Hide resolved
camilamacedo86
force-pushed
the
add-role
branch
from
6b1b9be
to
e02a5d4
Compare
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
added 2 commits
August 27, 2020 16:37
camilamacedo86
force-pushed
the
add-role
branch
from
e02a5d4
to
95416a2
Compare
joelanford
reviewed
Aug 27, 2020
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
Sep 17, 2020
…erator-framework#3779) Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Users identified that the tool was not scaffolding RBAC permissions which are required for the Helm operator works successfully in OCP.
Motivation for the change:
Closes: #3767