Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Ansible-based Operator, add .gitignore file which was missing. #3806

Merged
merged 4 commits into from Aug 31, 2020
Merged

For Ansible-based Operator, add .gitignore file which was missing. #3806

merged 4 commits into from Aug 31, 2020

Conversation

camilamacedo86
Copy link
Contributor

Description of the change:

  • For Ansible-based Operator, add .gitignore file which was missing.

Motivation for the change:

  • Following the good practices, users should not commit the binaries that are added to the bin/ dir.
  • Keep all projects/types following the same standard.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@camilamacedo86 camilamacedo86 changed the title bugfix: For Ansible-based Operator, add file which was missing. bugfix: For Ansible-based Operator, add .gitignore file which was missing. Aug 28, 2020
@camilamacedo86 camilamacedo86 requested review from asmacdo and joelanford and removed request for shawn-hurley and hasbro17 August 28, 2020 17:50
@camilamacedo86 camilamacedo86 changed the title bugfix: For Ansible-based Operator, add .gitignore file which was missing. For Ansible-based Operator, add .gitignore file which was missing. Aug 28, 2020
asmacdo
asmacdo approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, other than that lgtm

@camilamacedo86 camilamacedo86 added kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project labels Aug 30, 2020
jmrodri
jmrodri approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@camilamacedo86 camilamacedo86 merged commit 497b7f8 into operator-framework:master Aug 31, 2020
@camilamacedo86 camilamacedo86 deleted the ansible-gitignore branch August 31, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@asmacdo asmacdo asmacdo approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@fabianvf fabianvf Awaiting requested review from fabianvf

Assignees

@jmrodri jmrodri

Labels
kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camilamacedo86 @jmrodri @asmacdo @openshift-ci-robot