Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.19.x: Make bundle validate subcommand respect verbosity (#3795) #3812

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Aug 28, 2020

Cherry-picked from #3795

  • Make bundle validate subcommand respect verbosity

This makes the bundle validate subcommand respect the verbosity level
by setting it directly in the logger that's actually used, and not in
the global logger as was done previously.

Closes: #3793

  • add unit test

Co-authored-by: Austin Macdonald austin@redhat.com

NOTE:
I cherry-picked manually because the bot couldn't handle an imports merge conflict.

…#3795)

* Make bundle validate subcommand respect verbosity

This makes the bundle validate subcommand respect the verbosity level
by setting it directly in the logger that's actually used, and not in
the global logger as was done previously.

Closes: operator-framework#3793

* add unit test

Co-authored-by: Austin Macdonald <austin@redhat.com>
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@joelanford joelanford changed the title Make bundle validate subcommand respect verbosity (#3795) v0.19.x: Make bundle validate subcommand respect verbosity (#3795) Aug 28, 2020
@asmacdo asmacdo merged commit 92d8cee into operator-framework:v0.19.x Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants