Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: use the tags in the scorecard scaffolded manifests #3845

Merged
merged 2 commits into from Sep 10, 2020
Merged

bugfix: use the tags in the scorecard scaffolded manifests #3845

merged 2 commits into from Sep 10, 2020

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Sep 2, 2020 •
edited

Description of the change:

  • Scorecard manifests created using the image with tags.

Motivation for the change:

Closes: #3840

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@camilamacedo86 camilamacedo86 changed the title change: use the tags in the scorecard scaffolded manifests bugfix: use the tags in the scorecard scaffolded manifests Sep 2, 2020
@camilamacedo86 camilamacedo86 added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. scorecard Issue relates to the scorecard subcomponent and removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. labels Sep 2, 2020
@camilamacedo86 camilamacedo86 changed the title bugfix: use the tags in the scorecard scaffolded manifests wip; bugfix: use the tags in the scorecard scaffolded manifests Sep 9, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2020
@camilamacedo86 camilamacedo86 changed the title wip; bugfix: use the tags in the scorecard scaffolded manifests bugfix: use the tags in the scorecard scaffolded manifests Sep 9, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2020
joelanford
joelanford approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on the changelog line. Otherwise,
/lgtm

changelog/fragments/scorecard_scaffolded_version.yaml Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020
@camilamacedo86 @joelanford
Update changelog/fragments/scorecard_scaffolded_version.yaml
3947f15 
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020
@camilamacedo86 camilamacedo86 merged commit e0edd39 into operator-framework:master Sep 10, 2020
@camilamacedo86 camilamacedo86 deleted the fix-scafolded branch September 10, 2020 11:18
joelanford pushed a commit to joelanford/operator-sdk that referenced this pull request Sep 17, 2020
@camilamacedo86 @joelanford
bugfix: use the tags in the scorecard scaffolded manifests (operator-…
a5c2004 
…framework#3845)

**Description of the change:**
- Scorecard manifests created using the image with tags. 

**Motivation for the change:**

Closes: operator-framework#3840
@joelanford joelanford mentioned this pull request Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

Assignees

@joelanford joelanford

Labels
scorecard Issue relates to the scorecard subcomponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Projects has been scaffolded to use the master tag of scorecard instead of the latest release
3 participants
@camilamacedo86 @openshift-ci-robot @joelanford