[v1.0.x] *: fix run packagemanifests #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifests (operator-framework#3856) * internal/olm/operator: fix operator-registry image for run packagemanifests * internal/olm/client/client.go: return error for failed CSV * use switch for DoCSVWait phase logic * pin to olm 0.15.1 for integration tests
…tory to write files (operator-framework#3867)
joelanford
force-pushed
the
v1.0.x-fix-run-packagemanifests
branch
from
223d94b
to
ce9cf4f
Compare
hasbro17
reviewed
Sep 17, 2020
| if isRunningOnKind() { | ||
| By("loading the bundle image into Kind cluster") | ||
| err = tc.LoadImageToKindClusterWithName(bundleImage) | ||
| Expect(err).Should(Succeed()) |
There was a problem hiding this comment.
Nit: I know this is a backport and this line is basically unchanged in this PR but for better readability this probably should be:
Expect(err).NotTo(HaveOccurred())Succeed() is used more for the function itself:
Ω(DoSomethingSimple()).Should(Succeed())There was a problem hiding this comment.
+1 I'll make this comment into an issue. There are probably lots of instances of this that we can fix on master (probably not worth backporting those changes though).
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Backport #3856 and #3867
Motivation for the change:
Supported branches should get bug fixes. This unblocks CI, which is currently failing due to issues with OLM v0.16.1's caching of catalog data.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs