[olm] Store multiple versions of olm manifests #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@estroz @camilamacedo86 @joelanford - How many versions of OLM do you think we could support for a particular release. In the current PR, the thought is to have a sliding window of 5 versions. When we have a new SDK release, we will remove the oldest OLM version, and add a newer one. |
|
Hi @varshaprasad96, could you please rebase this one with the master and address the nits for we are able to move forward with? |
camilamacedo86
added
the
needs-rebase
varshaprasad96
force-pushed
the
olm/add-version-script
branch
from
e9a09aa
to
528bdf2
Compare
openshift-ci-robot
removed
the
needs-rebase
varshaprasad96
force-pushed
the
olm/add-version-script
branch
from
528bdf2
to
32291c5
Compare
camilamacedo86
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
It shows fine for me 👍
IMO it needs @estroz ok's as well since he is who is most involved.
estroz
reviewed
Nov 4, 2020
estroz
reviewed
Nov 4, 2020
This PR modifies the existing script to download multiple versions of olm manifests and generate bindata for all of them during release.
varshaprasad96
force-pushed
the
olm/add-version-script
branch
from
d8f028f
to
a3d2759
Compare
varshaprasad96
force-pushed
the
olm/add-version-script
branch
from
a3d2759
to
e59bb1f
Compare
|
New changes are detected. LGTM label has been removed. |
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
* [olm] Store multiple versions of olm manifests This PR modifies the existing script to download multiple versions of olm manifests and generate bindata for all of them during release. * Modify changes to samples * change the number stored olm versions Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
rearl-scwx
pushed a commit
to rearl-scwx/operator-sdk
that referenced
this pull request
Feb 5, 2021
* [olm] Store multiple versions of olm manifests This PR modifies the existing script to download multiple versions of olm manifests and generate bindata for all of them during release. * Modify changes to samples * change the number stored olm versions Signed-off-by: rearl <rearl@secureworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR modifies the existing script to download multiple versions
of olm manifests and generate bindata for all of them during release.
Motivation for the change:
Follow up from #3906
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs