[v1.0.x] fix: modify olm-status-descriptor-test in scorecard #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify `olm-status-descriptor-test` to not check the presence of `status` field in CR, instead validate only if status-descriptors are present in owned CRDs.
2 tasks
|
This doesn't quite fix the issue described in #3999 /hold |
openshift-ci-robot
added
the
do-not-merge/hold
jmrodri
approved these changes
Oct 22, 2020
| # release notes and/or the migration guide | ||
| entries: | ||
| - description: > | ||
| Modify `olm-status-descriptors-test` to only validate if the status-descriptors are present in CRD. |
There was a problem hiding this comment.
nit: changelog should be past tense: Modified
2 tasks
|
Once this is merged, #4093 can also be cherry picked |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
closing this and opening #4141 instead with same changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4009
/assign varshaprasad96