Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/olm-integration/generation.md: add optional validator operatorhub docs #4150

Merged

Conversation

varshaprasad96
Copy link
Member

Description of the change:
Add doc on validation of custom categories

Motivation for the change:
Follow up of #4109

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2020
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After to address the @estroz's comments it shows fine for me.
👍

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@estroz
Copy link
Member

estroz commented Oct 30, 2020

@varshaprasad96 can you change the commit/PR title to something that reflects these changes, like

docs/olm-integration/generation.md: add optional validator operatorhub docs

@camilamacedo86 camilamacedo86 merged commit 9e99cad into operator-framework:master Oct 31, 2020
@camilamacedo86 camilamacedo86 changed the title Add doc on validation of custom categories docs/olm-integration/generation.md: add optional validator operatorhub docs Oct 31, 2020
@varshaprasad96 varshaprasad96 deleted the doc/operator-verify branch November 10, 2020 03:55
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
…b docs (operator-framework#4150)

Description of the change:
Add doc on validation of custom categories

Motivation for the change:
Follow up of operator-framework#4109


Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants