test/integration: rewrite in BDD style, fixup cleanup command
#4303
Conversation
openshift-ci-robot
added
the
area/testing
estroz
force-pushed
the
chore/fix-integration-tests
branch
from
c685dc6
to
6a0046d
Compare
the Go memcached-operator sample, as well as fixes a few bugs. Makefile: call integration tests directly internal/generate/clusterserviceversion: use FromVersion correctly internal/olm/operator/uninstall.go: rewrite Run() so it cleans all possible resources up and reports whether a package ever existed correctly internal/testutils,docs: fix 'packagemanifests' target tests/integration: rewrite with Ginkgo/Gomega and use Go sample
estroz
force-pushed
the
chore/fix-integration-tests
branch
from
6a0046d
to
d9d0ba2
Compare
|
/cc @varshaprasad96 |
| @@ -38,7 +38,7 @@ endif | |||
| ifeq ($(IS_CHANNEL_DEFAULT), 1) | |||
| PKG_IS_DEFAULT_CHANNEL := --default-channel | |||
| endif | |||
| PKG_MAN_OPTS ?= $(FROM_VERSION) $(PKG_CHANNELS) $(PKG_IS_DEFAULT_CHANNEL) | |||
| PKG_MAN_OPTS ?= $(PKG_FROM_VERSION) $(PKG_CHANNELS) $(PKG_IS_DEFAULT_CHANNEL) | |||
There was a problem hiding this comment.
It shows required an entry + migration step for who is using this pkg manifests scaffold on the projects.
There was a problem hiding this comment.
They aren't scaffolded at all, the user has to add this themselves, so I don't think this is necessary. However it doesn't hurt to add one.
There was a problem hiding this comment.
They are not scaffolded. However, the user might have followed the docs and added these steps.
Then, we should provide the guidance to migrate it in the changelog.
There was a problem hiding this comment.
I saw that besides your comment you added the steps :https://github.com/operator-framework/operator-sdk/pull/4303/files#diff-53c8ad93e1bd0a81cd5a8264eedcdedc3106a4aad6d37e51bff38c42ad7f4704R9-R13 👍
So all good. Thank you.
There was a problem hiding this comment.
@estroz just a few nits regards the changelogs.
And then, we need to fix the CI jobs for netfly that are broken. Also, see my question
openshift-ci-robot
added
the
do-not-merge/hold
estroz
force-pushed
the
chore/fix-integration-tests
branch
from
3cd6a1c
to
85de42c
Compare
Not sure what's up with that. Its unrelated to this PR though. ping @asmacdo do we need to update website deps? |
…ator-framework#4303) Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
…ator-framework#4303) Signed-off-by: rearl <rearl@secureworks.com>
Description of the change:
Motivation for the change: This PR rewrites OLM integration tests in BDD style and using the Go memcached-operator sample, as well as fixes a few bugs (that aren't in a release AFAIK so no changelog needed). Additionally, the OLM component of Go e2e tests was removed because a more thorough test is already performed by the integration tests.
/area testing
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs