Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin top level Python dependencies #4321

Merged

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Dec 15, 2020

This rolls back the version of Ansible installed in the Ansible base
image, fixing a syntax error in the Dockerfile. ansible~=2.9 resolves to
Ansible 2.10, but should have been < 2.10.

This does not solve the related concern of helping users set up a local environment, which will be addressed in a followup PR.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@fabianvf
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
This rolls back the version of Ansible installed in the Ansible base
image, fixing a syntax error in the Dockerfile.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@asmacdo asmacdo merged commit 77f1b5e into operator-framework:master Dec 15, 2020
@estroz
Copy link
Member

estroz commented Dec 17, 2020

/cherry-pick v1.2.x

@openshift-cherrypick-robot

@estroz: new pull request created: #4327

In response to this:

/cherry-pick v1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
This rolls back the version of Ansible installed in the Ansible base
image, fixing a syntax error in the Dockerfile.

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
rearl-scwx pushed a commit to rearl-scwx/operator-sdk that referenced this pull request Feb 5, 2021
This rolls back the version of Ansible installed in the Ansible base
image, fixing a syntax error in the Dockerfile.
Signed-off-by: rearl <rearl@secureworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants