Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Python to v 3.8 #4413

Merged
merged 3 commits into from Feb 4, 2021

Conversation

reinvantveer
Copy link
Contributor

@reinvantveer reinvantveer commented Jan 20, 2021

Description of the change:
Upgrade Python to version 3.8 to facilitate local development (i.e. without having to resort to deadsnakes repos and suchlikes) and benefit from performance enhancements in more recent versions of Python (with 3.6 functionally mothballed now)

Motivation for the change:
The Ansible operator uses an outdated version of Python that hampers local development and reproducible builds as it requires you to keep around an old version of Python. Since many recent distros don't ship Python 3.6 in their standard packaging repositories anymore, this requires a manual install, or alternate package repositories.

Note: this is a first pull request to start addressing the issues mentioned in #4237

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
@reinvantveer
Copy link
Contributor Author

Re-committed to fix DCO signoffs

@dalbani
Copy link

dalbani commented Jan 20, 2021

And what about the use of latest in the base image FROM registry.access.redhat.com/ubi8/ubi:latest?
Instead of pinning to a specific version I mean, for reproducibility purposes.
Tag 8.3-227 is at the moment the latest release: https://catalog.redhat.com/software/containers/ubi8/ubi/5c359854d70cc534b3a3784e.

@estroz
Copy link
Member

estroz commented Jan 21, 2021

@dalbani that's a reasonable request. If ansible's base image is being pinned, helm's should as well. This should be done in a separate PR though.

@reinvantveer reinvantveer mentioned this pull request Jan 21, 2021
2 tasks
@jmrodri jmrodri self-requested a review January 31, 2021 04:57
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@jmrodri jmrodri merged commit df87e6c into operator-framework:master Feb 4, 2021
@reinvantveer reinvantveer deleted the upgrade_python branch February 4, 2021 07:07
@reinvantveer
Copy link
Contributor Author

Great, thanks

reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
* upgrade Python to v 3.8
* add change notes
* add python to installation guide

Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
* upgrade Python to v 3.8
* add change notes
* add python to installation guide

Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
* upgrade Python to v 3.8
* add change notes
* add python to installation guide

Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
* upgrade Python to v 3.8
* add change notes
* add python to installation guide

Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
* upgrade Python to v 3.8
* add change notes
* add python to installation guide

Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
rearl-scwx pushed a commit to rearl-scwx/operator-sdk that referenced this pull request Feb 5, 2021
* upgrade Python to v 3.8
* add change notes
* add python to installation guide

Signed-off-by: reinvantveer <reinvantveer@gmail.com>Signed-off-by: rearl <rearl@secureworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants