New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate: fix multiple Go file type parsing bug #4507
Conversation
untyped and Typ-typed *ast.Object's that underly an *ast.Ident, such that types in other files are found properly Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
the tests helped me understand what was going on. +1
/cherry-pick v1.3.x |
@estroz: new pull request created: #4508 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick v1.4.x |
@estroz: new pull request created: #4509 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Motivation for the change: see #3744
Closes #3744
/kind bug
Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs