ansible/helm: add ssc to not allow root previleges #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
force-pushed
the
add-ssc-ansible-helm
branch
from
03faf5a
to
16b0302
Compare
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
add-ssc-ansible-helm
branch
from
16b0302
to
7daef58
Compare
camilamacedo86
force-pushed
the
add-ssc-ansible-helm
branch
from
7daef58
to
59bf269
Compare
camilamacedo86
force-pushed
the
add-ssc-ansible-helm
branch
from
59bf269
to
418d6f8
Compare
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
suggested changes
Mar 15, 2021
| # release notes and/or the migration guide | ||
| entries: | ||
| - description: > | ||
| (ansible/v1)(helm/v1) Add SecurityContext to now allow root privileges. |
There was a problem hiding this comment.
Suggested change
| (ansible/v1)(helm/v1) Add SecurityContext to now allow root privileges. | |
| (ansible/v1, helm/v1) Added `securityContext`'s to the manager's Deployment to disallow running as root user. |
| # Migration can be defined to automatically add a section to | ||
| # the migration guide. This is required for breaking changes. | ||
| migration: | ||
| header: (ansible/v1)(helm/v1) **(Optional)** Add SecurityContext to now allow root privileges. |
There was a problem hiding this comment.
All v1.y migrations are optional.
Suggested change
| header: (ansible/v1)(helm/v1) **(Optional)** Add SecurityContext to now allow root privileges. | |
| header: (ansible/v1, helm/v1) Add `securityContext`'s to your manager's Deployment. |
| migration: | ||
| header: (ansible/v1)(helm/v1) **(Optional)** Add SecurityContext to now allow root privileges. | ||
| body: > | ||
| In the `config/manager` add the following security context: |
There was a problem hiding this comment.
Suggested change
| In the `config/manager` add the following security context: | |
| In `config/manager/manager.yaml`, add the following security contexts: |
| body: > | ||
| In the `config/manager` add the following security context: | ||
| ```yaml | ||
| spec: |
There was a problem hiding this comment.
Can you indent these from the root field, ex
spec:
...
template:
...
spec:
securityContext:
runAsNonRoot: true
containers:
- name: manager
securityContext:
allowPrivilegeEscalation: falseSigned-off-by: Camila Macedo <cmacedo@redhat.com>
camilamacedo86
force-pushed
the
add-ssc-ansible-helm
branch
from
418d6f8
to
5bec9e1
Compare
waynesun09
added a commit
to waynesun09/reportportal-operator
that referenced
this pull request
Apr 22, 2021
This is related to upgrade operator-sdk to v1.6.0: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.6.0/ operator-framework/operator-sdk#4655 Signed-off-by: Wayne Sun <gsun@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Camila Macedo cmacedo@redhat.com
Description of the change:
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs