New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible/helm: add makefile helper #4660
ansible/helm: add makefile helper #4660
Conversation
seems to work fine. I worry about this just being text in a template somewhere, though - one more thing we have to remember to update if anything changes. |
5e2fb4a
to
11219c7
Compare
Ansible/Helm projects scaffolded by the tool now provides a Makefile | ||
helper. To address these changes you can copy and paste the Makefile from | ||
its samples which are in the testdata. Check the latest version of the | ||
Helm Makefile [here](https://github.com/operator-framework/operator-sdk/blob/v1.6.0/testdata/helm/memcached-operator/Makefile) and check it for Ansible [here](https://github.com/operator-framework/operator-sdk/blob/v1.6.0/testdata/ansible/memcached-operator/Makefile). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ansible/Helm projects scaffolded by the tool now provides a Makefile | |
helper. To address these changes you can copy and paste the Makefile from | |
its samples which are in the testdata. Check the latest version of the | |
Helm Makefile [here](https://github.com/operator-framework/operator-sdk/blob/v1.6.0/testdata/helm/memcached-operator/Makefile) and check it for Ansible [here](https://github.com/operator-framework/operator-sdk/blob/v1.6.0/testdata/ansible/memcached-operator/Makefile). | |
Ansible/Helm projects now provide a Makefile `help` target, similar to a `--help` flag. | |
You can copy and paste this target from the relevant sample's Makefile | |
([helm]((https://github.com/operator-framework/operator-sdk/blob/v1.5.0/testdata/helm/memcached-operator/Makefile), [ansible]((https://github.com/operator-framework/operator-sdk/blob/v1.5.0/testdata/ansible/memcached-operator/Makefile)). |
# Migration can be defined to automatically add a section to | ||
# the migration guide. This is required for breaking changes. | ||
migration: | ||
header: (helm/v1,ansible/v1) - **(Optional)** Add Makefile helper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
header: (helm/v1,ansible/v1) - **(Optional)** Add Makefile helper | |
header: (helm/v1, ansible/v1) Add `help` target to Makefile. |
.PHONY: kustomize ## Download kustomize locally if necessary. | ||
KUSTOMIZE = $(shell pwd)/bin/kustomize | ||
kustomize: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.PHONY: kustomize ## Download kustomize locally if necessary. | |
KUSTOMIZE = $(shell pwd)/bin/kustomize | |
kustomize: | |
.PHONY: kustomize | |
KUSTOMIZE = $(shell pwd)/bin/kustomize | |
kustomize: ## Download kustomize locally if necessary. |
.PHONY: ansible-operator ## Download ansible-operator locally if necessary, preferring the $(pwd)/bin path over global if both exist. | ||
ANSIBLE_OPERATOR = $(shell pwd)/bin/ansible-operator | ||
ansible-operator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.PHONY: ansible-operator ## Download ansible-operator locally if necessary, preferring the $(pwd)/bin path over global if both exist. | |
ANSIBLE_OPERATOR = $(shell pwd)/bin/ansible-operator | |
ansible-operator: | |
.PHONY: ansible-operator | |
ANSIBLE_OPERATOR = $(shell pwd)/bin/ansible-operator | |
ansible-operator: ## Download ansible-operator locally if necessary, preferring the $(pwd)/bin path over global if both exist. |
11219c7
to
5e3cc8e
Compare
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
5e3cc8e
to
251c01e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Camila Macedo cmacedo@redhat.com
Description of the change:
add makefile helper for ansible/helm
Motivation for the change:
provide for ansible/helm the same nice features that we have for Go
Closes: #4628
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs