run bundle(-upgrade): configure registry pod with root certificate secret
#4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/feature
|
This is blocked by an Docs need to be updated. I'd also like to hear whether using a secret is preferable to a file directly. I prefer the former because the user invoking /hold |
openshift-ci-robot
added
the
do-not-merge/hold
estroz
force-pushed
the
feature/registry-pod-ca-file
branch
from
48c8183
to
b0b9be9
Compare
|
/retest |
|
operator-framework/operator-registry#611 was merged and a new /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
estroz
force-pushed
the
feature/registry-pod-ca-file
branch
from
b0b9be9
to
4d236ef
Compare
bundles hosted by a registry using a custom CA can configure the registry Pod's `opm registry add` command with the root cert file. internal/olm/operator/registry: rename `--secret-name` to `--pull-secret-name` to disambiguate new flag docs/: consolidate private/custom CA registry configuration details into an olm-integration doc Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz
force-pushed
the
feature/registry-pod-ca-file
branch
from
4d236ef
to
31cbc82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
--ca-secret-nameto accept the name of a secret containing a root certificate file.Motivation for the change: This PR adds
--ca-secret-nameso users attempting to run bundles hosted by a registry using a custom CA can configure the registry Pod'sopm registry addcommand with the root cert file.Closes #4650
/kind feature
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs