New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible bump deps #4734
Ansible bump deps #4734
Conversation
fe235ac
to
3c9edad
Compare
# release notes and/or the migration guide | ||
entries: | ||
- description: > | ||
Update dependencies for Ansible-based Operators. Pulls in 0.12 of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update dependencies for Ansible-based Operators. Pulls in 0.12 of the | |
For Ansible-based Operators, update of dependencies. Pulls in 0.12 of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits.
- According to the template, we ought to For Language-based ... Please, give a look at the template.
- Also, we might need to create another one for the scaffolds using (ansible/v1) update of the dependencies and with the steps in the migration section to let the users are able to do that manually
- Then, it is missing
(
)` for the versions and the info from X to Y.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits regarding the fragment. Otherwise,
lgtm
Regenerate samples Add changelog Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
3c9edad
to
839071e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
/lgtm |
Description of the change:
Bring python and Ansible dependencies up to date
Motivation for the change:
Lots of work going on in the kubernetes and operator_sdk collection, want to make sure we keep up with those dependencies.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs