Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible bump deps #4734

Merged
merged 2 commits into from Apr 9, 2021
Merged

Conversation

fabianvf
Copy link
Member

@fabianvf fabianvf commented Apr 8, 2021

Description of the change:
Bring python and Ansible dependencies up to date

Motivation for the change:
Lots of work going on in the kubernetes and operator_sdk collection, want to make sure we keep up with those dependencies.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

# release notes and/or the migration guide
entries:
- description: >
Update dependencies for Ansible-based Operators. Pulls in 0.12 of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Update dependencies for Ansible-based Operators. Pulls in 0.12 of the
For Ansible-based Operators, update of dependencies. Pulls in 0.12 of the

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits.

  • According to the template, we ought to For Language-based ... Please, give a look at the template.
  • Also, we might need to create another one for the scaffolds using (ansible/v1) update of the dependencies and with the steps in the migration section to let the users are able to do that manually
  • Then, it is missing ()` for the versions and the info from X to Y.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits regarding the fragment. Otherwise,

lgtm

Regenerate samples

Add changelog

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021
@jmrodri
Copy link
Member

jmrodri commented Apr 9, 2021

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants