Add logs that allow users to see what events the controller is receiving #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
fabianvf
force-pushed
the
ansible-logging-event-handler
branch
3 times, most recently
from
9b7cd99
to
3e66b56
Compare
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
* Add prometheus/client_model dependency Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
ansible-logging-event-handler
branch
from
3e66b56
to
2f21571
Compare
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
ansible-logging-event-handler
branch
from
c556bbb
to
e0a54cf
Compare
fabianvf
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign |
fabianvf
commented
Apr 27, 2021
estroz
reviewed
Apr 27, 2021
Co-authored-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
ansible-logging-event-handler
branch
from
13e2897
to
cdd8834
Compare
estroz
reviewed
Apr 27, 2021
estroz
reviewed
Apr 27, 2021
estroz
reviewed
Apr 27, 2021
estroz
reviewed
Apr 27, 2021
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us> Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
estroz
approved these changes
Apr 27, 2021
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
ansible-logging-event-handler
branch
from
bee1354
to
fce10d7
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adds event handlers that emit a log signaling what events are coming in and what primary resource it will map to.
This is currently just for the ansible-operator specifically, it may be that these changes are better suited to
operator-liborcontroller-runtime, but I wanted people to be able to work with a basic implementation before I started working on a more complete solution.Motivation for the change:
For Ansible-based Operators specifically, we've frequently had issues with infinite reconciliation loops caused by controllers wrestling over a resource, but what resource is causing the issue is completely opaque to the user. This should make debugging those kinds of issues significantly easier.
Fixes #3945
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs