New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate packagemanifests commands #4838
Merged
varshaprasad96
merged 1 commit into
operator-framework:master
from
varshaprasad96:deprecate/pkgman
Apr 30, 2021
Merged
Deprecate packagemanifests commands #4838
varshaprasad96
merged 1 commit into
operator-framework:master
from
varshaprasad96:deprecate/pkgman
Apr 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshaprasad96
force-pushed
the
deprecate/pkgman
branch
from
April 28, 2021 23:33
5b5fe2f
to
e3c623a
Compare
jmrodri
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
varshaprasad96
force-pushed
the
deprecate/pkgman
branch
from
April 29, 2021 02:17
e3c623a
to
12d5419
Compare
varshaprasad96
commented
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
estroz
reviewed
Apr 29, 2021
internal/cmd/operator-sdk/run/packagemanifests/packagemanifests.go
Outdated
Show resolved
Hide resolved
Deprecate run packagemanifests and generate packagemanifests command in favour of bundle format. Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
deprecate/pkgman
branch
from
April 30, 2021 00:08
12d5419
to
c1b1f09
Compare
estroz
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Deprecate run packagemanifests and generate packagemanifests command
in favour of bundle format.
Signed-off-by: varshaprasad96 varshaprasad96@gmail.com
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs