Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): bump dependencies to resolve CVE issues #6383

Merged
merged 6 commits into from
Jun 21, 2023
Merged

(chore): bump dependencies to resolve CVE issues #6383

merged 6 commits into from
Jun 21, 2023

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Mar 30, 2023 •
edited

Description of the change:

  • Bump the following dependencies to ensure we aren't using versions resulting in twistlock scan issue:
    • github.com/emicklei/go-restful/v3 --> v3.10.0
    • github.com/golang-jwt/jwt/v4 --> v4.5.0
    • golang.org/x/net --> v0.10.0
    • helm.sh/helm/v3 --> v3.11.3
    • github.com/containerd/containerd --> v1.7.0
    • github.com/docker/docker --> v20.10.24
  • Bump the github.com/operator-framework/operator-registry dependency to v1.28.0 to pull in some related cve fixes

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@everettraven
bump deps to fix twistlock scan issue
b593910 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:16 — with GitHub Actions Inactive
@everettraven
update golang-jwt
0c90b22 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:19 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:19 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:23 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:24 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:26 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:26 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:27 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy March 30, 2023 20:27 — with GitHub Actions Inactive
everettraven
everettraven commented Mar 31, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@everettraven
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@ukumar009
Copy link
Contributor

Hi @everettraven

I see you are not able to merge this Pull Request due to github.com/distribution/distribution/v3

Could you please consider merging this CVE github.com/emicklei/go-restful/v3 --> v3.10.0 in a separate PR? Because this is a High Vulnerability CVE.

Or May I create a Separate Pull Request for the github.com/emicklei/go-restful/v3? Apologies for the inconvenience.

Thanks,

@everettraven
update dependencies to fix some CVEs
5a865e1 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy June 21, 2023 15:24 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 15:24 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 15:24 — with GitHub Actions Inactive
@everettraven everettraven changed the title (chore): bump deps to fix twistlock scan issue (chore): bump dependencies to resolve CVE issues Jun 21, 2023
@ukumar009
Copy link
Contributor

Thank you @everettraven

@everettraven
fix opentelemetry dep issues
aa1a75f 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:20 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:20 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:20 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:20 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:20 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:20 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:22 — with GitHub Actions Inactive
@everettraven
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2023
@everettraven
fix sanity failures
2301cd0 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:39 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:39 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:39 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:39 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:39 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:39 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 21, 2023 16:39 — with GitHub Actions Inactive
rashmigottipati
rashmigottipati approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@everettraven everettraven merged commit deb20c6 into operator-framework:master Jun 21, 2023
29 checks passed
@acornett21 acornett21 mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@anik120 anik120 Awaiting requested review from anik120

@theishshah theishshah Awaiting requested review from theishshah

Assignees

@rashmigottipati rashmigottipati

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
3 participants
@everettraven @ukumar009 @rashmigottipati