BundleDeployment: add and implement required serviceAccountName and installNamespace fields #857
+248
−943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hacking a bit on rukpak BundleDeployment to put the following new required fields in the spec:
In the reconciler, I've removed all cluster-admin-like permissions and replaced them with just permission to create token requests.
I've also reorganized helm-operator-plugins a bit:
Lastly, I've added a token getter/cache implementation and updated the setup of the controllers in rukpak's main.go files to use that for the actionConfigGetter configuration.
With all of that, I've run a few tests with permissions missing and with all permissions present, and things seem to work.
This is a WIP because nothing in helm-operator-plugins is merged, and I've pinned to my local copy that combines both of the above PRs.