bump go 1.22 and k8s deps 0.30.0 #890
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
everettraven
force-pushed
the
chore/bump-k8s-1.30
branch
from
7d7e747
to
d7880c2
Compare
everettraven
changed the title
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: everettraven <everettraven@gmail.com>
Signed-off-by: everettraven <everettraven@gmail.com>
everettraven
force-pushed
the
chore/bump-k8s-1.30
branch
from
18b79e1
to
bade292
Compare
openshift-merge-robot
removed
the
needs-rebase
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
===========================================
- Coverage 37.95% 15.06% -22.90%
===========================================
Files 9 40 +31
Lines 843 2443 +1600
===========================================
+ Hits 320 368 +48
- Misses 481 2018 +1537
- Partials 42 57 +15 ☔ View full report in Codecov by Sentry. |
| github.com/operator-framework/helm-operator-plugins v0.2.1 | ||
| github.com/operator-framework/operator-registry v1.40.0 | ||
| github.com/operator-framework/api v0.24.0 | ||
| github.com/operator-framework/helm-operator-plugins v0.2.2-0.20240520180534-f463c36fedf9 |
There was a problem hiding this comment.
Only reason I am pinning on a commit is because I wasn't sure if we wanted to cut a release of helm-operator-plugins since the Kubebuilder dependency was not updated to one that supports go 1.22 and k8s 1.30 for scaffolding.
Happy to discuss this further (and cut a release if desired), but if we don't intend to cut a release for helm-operator-plugins in the very near future I'd prefer to get this in as is to unblock the CRD Upgrade Safety preflight check work
There was a problem hiding this comment.
Is helm-operator-plugins scaffolding still working right now with your changes that just merged? If so, I see no reason not to go ahead and tag it.
There was a problem hiding this comment.
I believe so. I can go ahead and tag it.
There was a problem hiding this comment.
As found in https://kubernetes.slack.com/archives/C0181L6JYQ2/p1716234751101299 the scaffolding is broken and should be fixed in helm-operator-plugins before being tagged. To unblock the in-flight CRD upgrade safety preflight check work we will capture fixing that in an issue to be addressed before tagging and will be keeping this pinned on a commit in the meantime
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
Changes look good to me! Will leave final approval to @joelanford
5830540
No description provided.