Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#53669] Change default view for meetings module to upcoming invitations #15495

Conversation

mrmir
Copy link
Contributor

@mrmir mrmir commented May 7, 2024

@mrmir mrmir added the feature label May 7, 2024
@mrmir mrmir self-assigned this May 7, 2024
@mrmir mrmir marked this pull request as ready for review May 14, 2024 10:52
@aaron-contreras aaron-contreras self-requested a review May 27, 2024 12:56
Copy link
Contributor

@aaron-contreras aaron-contreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. There's only one little caveat (I checked though and it is already a bug on the dev branch so it wasn't introduced by this PR).

On "light mode" the menu item is properly highlighted:
Menu item highlighted

On "High contrast mode" the menu items do not highlight when selected:
image

The acceptance criteria on the work package specifies that the menu entry should be highlighted (but again, probably was written up from a "Light" mode and not a "High contrast mode"). If you could fix this, great :) but it was already a bug present on the current dev branch.

@mrmir
Copy link
Contributor Author

mrmir commented May 27, 2024

I poked around for a bit but couldn't fix it quickly, so I'll create a separate bug ticket for this issue. It seems to be happening everywhere, and not just in meetings, so I think that makes more sense to do anyway.

@mrmir mrmir merged commit ec5ff1a into dev May 27, 2024
10 checks passed
@mrmir mrmir deleted the feature/53669-change-default-view-for-meetings-module-to-upcoming-invitations branch May 27, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants