Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade prawn 2.4.0 due to Embedded Font problem in Chrome (windows only) and Acrobat #15521

Merged
merged 1 commit into from
May 14, 2024

Conversation

Eric-Guo
Copy link
Contributor

Upstream issue

Below is the problem PDF file:

image

@ulferts
Copy link
Contributor

ulferts commented May 14, 2024

@Eric-Guo thanks for the PR.

@as-op can you please look into this?

@klaustopher klaustopher requested a review from as-op May 14, 2024 08:49
@as-op as-op self-assigned this May 14, 2024
@Eric-Guo
Copy link
Contributor Author

I can confirm Acrobat Pro DC 2023.001 ~ Acrobat Pro DC 2024.002 all having missing fonts issue. some smart PDF reader, like PDF Expert / FoxReader will resolve missing fonts problem automatically. So not every PDF reader having problem.

@as-op
Copy link
Contributor

as-op commented May 14, 2024

Thank you @Eric-Guo for bringing this to our attention!

I tried with Acrobat Reader 2024.002.20287, but that is not affected. As there is a reproducible case in the linked upstream issue and the confirmation by @Eric-Guo we should downgrade.

Our dependency md-to-pdf is still on prawn 2.4.0 anyhow, so the downgrade should be safe.
I verified this PR, it successfully downgrades to unaffected gem versions.

% bundle exec gem list --all --exact prawn ttfunk pdf-core

*** LOCAL GEMS ***

prawn (2.4.0)

*** LOCAL GEMS ***

ttfunk (1.7.0)

*** LOCAL GEMS ***

pdf-core (0.9.0)

@as-op as-op merged commit a137293 into opf:dev May 14, 2024
4 checks passed
@as-op as-op mentioned this pull request May 14, 2024
@Eric-Guo Eric-Guo deleted the embedded_font_failed branch May 16, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants