Add OAuth application flow for builtin mobile app #15541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
feature/53620/builtin-oauth-app-mobile
branch
from
d0b6a17
to
f17ce22
Compare
oliverguenther
force-pushed
the
feature/53620/builtin-oauth-app-mobile
branch
from
f17ce22
to
0b5ef1d
Compare
ulferts
requested changes
May 28, 2024
| redirect_uri: "openprojectapp://oauth-callback", | ||
| builtin: true, | ||
| confidential: false, | ||
| uid: "DgJZ7Rat23xHZbcq_nxPg5RUuxljonLCN7V7N7GoBAA" |
There was a problem hiding this comment.
💡 Since the UID is not secret it might help consumers to use something that is more readable, e.g. OpenProjectAppUID (and something more if filling is necessary)
| I18n.t(:button_activate), | ||
| toggle_oauth_application_path(application), | ||
| class: "oauth-application--edit-link icon icon-unlock", | ||
| method: :post |
There was a problem hiding this comment.
This leads to a link without icon which is unusual for the table:
AFAIK, the intend is to move away from link to button based actions completely but this might be for a different time.
There was a problem hiding this comment.
A somewhat unrelated question: Why not allow toggling the active status for all applications?
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
This has no specs whatsoever. Since it is the piece of code guarding against invalid changes, having specs ensures everything is working as desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/53620