rename persisted project query #15559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toy
force-pushed
the
feature/51673-renaming-persisted-project-lists
branch
8 times, most recently
from
61c591c
to
c60f76c
Compare
toy
force-pushed
the
feature/51673-renaming-persisted-project-lists
branch
from
c60f76c
to
e469061
Compare
toy
force-pushed
the
feature/51673-renaming-persisted-project-lists
branch
from
434ee24
to
1a0ba25
Compare
toy
commented
May 23, 2024
|
|
||
| def initialize(query:) | ||
| super() | ||
| @query = query |
There was a problem hiding this comment.
I didn't find a way to get model (query) from the ApplicationForm, so simpler and probably cleaner to just pass it
klaustopher
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#51673
Includes rework of projects menu, with two goals - properly marking list selected from both project and project queries controller for all actions and fixing the bug with marking menu item if there was query_id param even on unrelated pages (work_packages persisted lists) or marking the «Active projects» when there were no params.
Also split huge persisting queries spec into multiple smaller ones.