Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3912: Added local property protobuf condition for M1 Mac #3891

Merged
merged 3 commits into from Oct 12, 2021

Conversation

FareesHussain
Copy link
Contributor

@FareesHussain FareesHussain commented Oct 6, 2021

Fixes #3912

protoc-3.8.0-osx-aarch_64.exe is not available in 3.8.0 release and gives the following error on build
image

Here to fix this we the following property to local.properties (Only for M1 Mac) which uses osx release instead for the given condition when built on gradle.

protobuf_platform=osx-x86_64

PS: This issue doesn't appear for bazel build

@BenHenning
Copy link
Sponsor Member

BenHenning commented Oct 7, 2021

Thanks @FareesHussain. Nice fix. Some questions:

  1. Is there a tracking issue on protoc's GitHub repo tracking this issue that we can point to?
  2. If (1) doesn't exist, could you file one? It seems like a nice thing to do for a fellow open source project.
  3. Could you file an issue on our repository to add references to anywhere that helped solve this, to capture the context above, and to link to the GitHub issue for protoc?
  4. Could you update the comment to point to the issue from (2) as a reference?
  5. Could you update the PR to mark the new issue as fixed?

I think this'll better help centralize the investigation to an issue (which is the default place where investigation contexts should live for each consulting in the future).

@vinitamurthi vinitamurthi removed their assignment Oct 7, 2021
@oppiabot
Copy link

oppiabot bot commented Oct 7, 2021

Assigning @BenHenning for code owner reviews. Thanks!

@FareesHussain
Copy link
Contributor Author

Thanks @FareesHussain. Nice fix. Some questions:

  1. Is there a tracking issue on protoc's GitHub repo tracking this issue that we can point to?

Yes, there is (grpc/grpc-java#7690). this is where i found the solution.

  1. If (1) doesn't exist, could you file one? It seems like a nice thing to do for a fellow open source project.
  2. Could you file an issue on our repository to add references to anywhere that helped solve this, to capture the context above, and to link to the GitHub issue for protoc?

Done, #3912

  1. Could you update the comment to point to the issue from (2) as a reference?

Since the issue is already filed I didn't have to create these issues, protocolbuffers/protobuf#8557 grpc/grpc-java#7690

  1. Could you update the PR to mark the new issue as fixed?

Done

I think this'll better help centralize the investigation to an issue (which is the default place where investigation contexts should live for each consulting in the future).

@FareesHussain FareesHussain changed the title Added local property protobuf condition for M1 Mac Fix #3912: Added local property protobuf condition for M1 Mac Oct 7, 2021
@FareesHussain FareesHussain removed their assignment Oct 7, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FareesHussain. Just one follow-up.

model/build.gradle Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FareesHussain. I think I wasn't very clear in my earlier comment, but I think the latest is a bit clearer. Please resolve & send back. PR otherwise LGTM.

Comment on lines 6 to 7
// To build protoc in M1 mac. For Context, see:
// https://github.com/grpc/grpc-java/issues/7690.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// To build protoc in M1 mac. For Context, see:
// https://github.com/grpc/grpc-java/issues/7690.
// To build protoc in M1 mac. For context, see: #3912.

Prefer linking to our issue for context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Co-authored-by: Ben Henning <henning.benmax@gmail.com>
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the fast fix @FareesHussain! LGTM.

@BenHenning BenHenning merged commit f266da8 into develop Oct 12, 2021
@BenHenning BenHenning deleted the protobuf-in-m1 branch October 12, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aarch_64 release of protoc doesn't exist [M1 mac]
3 participants