New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3912: Added local property protobuf condition for M1 Mac #3891
Conversation
Thanks @FareesHussain. Nice fix. Some questions:
I think this'll better help centralize the investigation to an issue (which is the default place where investigation contexts should live for each consulting in the future). |
Assigning @BenHenning for code owner reviews. Thanks! |
Yes, there is (grpc/grpc-java#7690). this is where i found the solution.
Done, #3912
Since the issue is already filed I didn't have to create these issues, protocolbuffers/protobuf#8557 grpc/grpc-java#7690
Done
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FareesHussain. Just one follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FareesHussain. I think I wasn't very clear in my earlier comment, but I think the latest is a bit clearer. Please resolve & send back. PR otherwise LGTM.
model/build.gradle
Outdated
// To build protoc in M1 mac. For Context, see: | ||
// https://github.com/grpc/grpc-java/issues/7690. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// To build protoc in M1 mac. For Context, see: | |
// https://github.com/grpc/grpc-java/issues/7690. | |
// To build protoc in M1 mac. For context, see: #3912. |
Prefer linking to our issue for context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Ben Henning <henning.benmax@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the fast fix @FareesHussain! LGTM.
Fixes #3912
protoc-3.8.0-osx-aarch_64.exe is not available in 3.8.0 release and gives the following error on build
Here to fix this we the following property to local.properties (Only for M1 Mac) which uses osx release instead for the given condition when built on gradle.
PS: This issue doesn't appear for bazel build