-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #129 (from release-scripts repo): Handle FIREBASE_CONFIG_*
constants to allow for one release candidate
#19941
Fix #129 (from release-scripts repo): Handle FIREBASE_CONFIG_*
constants to allow for one release candidate
#19941
Conversation
Hi @JayVivarekar, can you complete the following:
|
Hi @vojtechjelinek, @DubeySandeep, @kevintab95, PTAL at this PR, it modifies files in jobs or platform folders. |
FIREBASE_CONFIG_*
constants to allow for one release candidate
@JayVivarekar Do you have any updates on this PR, per our recent discussion? (Did you manage to sort out the mocking issue?) Thanks! |
Hi @JayVivarekar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @JayVivarekar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @JayVivarekar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @JayVivarekar, can you complete the following:
|
Hi @JayVivarekar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Overview
the cause of the bug was, and which PR introduced it]
Essential Checklist
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers