Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to Docker #19962

Closed
wants to merge 66 commits into from
Closed

Migrate CI to Docker #19962

wants to merge 66 commits into from

Conversation

gp201
Copy link
Member

@gp201 gp201 commented Mar 16, 2024

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: [Explain here what your PR does and why]
  3. (For bug-fixing PRs only) The original bug occurred because: [Explain what
    the cause of the bug was, and which PR introduced it]

Essential Checklist

  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have followed the instructions for making a code change.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
  • The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)

Testing doc (for PRs with Beam jobs that modify production server data)

  • A testing doc has been written: ... (ADD LINK) ...
  • (To be confirmed by the server admin) All jobs in this PR have been verified on a live server, and the PR is safe to merge.

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

gp201 added 30 commits March 11, 2024 20:26
@seanlip
Copy link
Member

seanlip commented Apr 28, 2024

Thanks @jayam04 -- the issue looks good, but I have some concerns about merging this with 6 known flakes that are likely to keep cropping up and blocking developers from merging things. It's going to make the dev workflow very tedious if developers have to keep rerunning the tests again and again.

I think it'd still be good to file the issues now, but after that, could you work with folks to try and fix them before we merge this PR? @jnvtnguyen has been doing some flake fixes recently, and might be a good person to ask for tips/help.

Thanks!

@seanlip seanlip removed their assignment Apr 28, 2024
…n in backend_tests.yml and e2e_lighthouse_performance_acceptance_tests.yml
@gp201
Copy link
Member Author

gp201 commented May 1, 2024

Copy link
Contributor

@Lawful2002 Lawful2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files

Copy link

oppiabot bot commented May 8, 2024

Unassigning @Lawful2002 since they have already approved the PR.

@gp201
Copy link
Member Author

gp201 commented May 9, 2024

Hi @U8NWXD,

Apologies for the trouble, and thanks for your patience. Since this PR is time-sensitive, could you quickly check out the other comments?

Right now, I'm focusing on resolving the comments provided in these two discussions:

  1. Migrate CI to Docker #19962 (comment)
  2. Migrate CI to Docker #19962 (comment)

@U8NWXD
Copy link
Member

U8NWXD commented May 12, 2024

I've replied to or resolved my responded-to comments

@U8NWXD U8NWXD removed their assignment May 12, 2024
Copy link

oppiabot bot commented May 21, 2024

Hi @gp201, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants