New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI to Docker #19962
Migrate CI to Docker #19962
Conversation
…eptance_tests.yml
…est to run_backend_tests.py
Thanks @jayam04 -- the issue looks good, but I have some concerns about merging this with 6 known flakes that are likely to keep cropping up and blocking developers from merging things. It's going to make the dev workflow very tedious if developers have to keep rerunning the tests again and again. I think it'd still be good to file the issues now, but after that, could you work with folks to try and fix them before we merge this PR? @jnvtnguyen has been doing some flake fixes recently, and might be a good person to ask for tips/help. Thanks! |
…n in backend_tests.yml and e2e_lighthouse_performance_acceptance_tests.yml
I have addressed some of the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for codeowner files
Unassigning @Lawful2002 since they have already approved the PR. |
Hi @U8NWXD, Apologies for the trouble, and thanks for your patience. Since this PR is time-sensitive, could you quickly check out the other comments? Right now, I'm focusing on resolving the comments provided in these two discussions: |
I've replied to or resolved my responded-to comments |
Hi @gp201, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Overview
the cause of the bug was, and which PR introduced it]
Essential Checklist
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers