Implements part of #17712 : Acceptance tests for CUJs in the history tab of the exploration creator. #20191

Akhilesh-max · 2024-04-21T19:37:44Z

Overview

This PR fixes or fixes part of Acceptance Testing - covering all user journeys in form of user stories #17712
This PR does the following: Adds the acceptance test for the following CUJs in exploration editor section.

(serial numbers same as testing spreadsheet row number for each user type)

Essential Checklist

Please follow the instructions for making a code change.

I have linked the issue that this PR fixes in the "Development" section of the sidebar.
I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
I have written tests for my code.
The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

oppiabot · 2024-04-21T19:37:46Z

Hi @Akhilesh-max, can you complete the following:

The body of this PR is missing the proof that changes are correct section, please update it to include the section.
Thanks!

oppiabot · 2024-04-21T19:37:56Z

Hi @Akhilesh-max please assign the required reviewer(s) for this PR. Thanks!

oppiabot · 2024-04-22T05:45:57Z

Hi @Akhilesh-max. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

StephenYu2018

Several concerns.

core/tests/puppeteer-acceptance-tests/user-utilities/exploration-editor-utils.ts

oppiabot · 2024-05-01T04:21:05Z

Unassigning @Akhilesh-max since a re-review was requested. @Akhilesh-max, please make sure you have addressed all review comments. Thanks!

StephenYu2018

Resolved most of my previous comments, with the exception of one.

Also, there's one new concern from me.

core/tests/puppeteer-acceptance-tests/user-utilities/exploration-editor-utils.ts

oppiabot · 2024-05-01T18:30:03Z

Unassigning @StephenYu2018 since the review is done.

oppiabot · 2024-05-01T18:30:06Z

Hi @Akhilesh-max, it looks like some changes were requested on this pull request by @StephenYu2018. PTAL. Thanks!

… oppia-11

Akhilesh-max · 2024-05-03T09:13:08Z

Thanks @StephenYu2018. Addressed all your comments, I am stuck somewhere, as well. Have left a comment.

Akhilesh-max · 2024-05-03T09:39:39Z

core/tests/puppeteer-acceptance-tests/user-utilities/exploration-editor-utils.ts

+   * Downloads a specific version.
+   * @param {number} version - The version number to be downloaded.
+   */
+  async downloadVersion(version: number): Promise<void> {


@imchristie @seanlip @StephenYu2018
I need to confirm this download, wherein this download initiates on clicking the download button which in turn opens a new tab. However, this tab closes too quickly to read any event or fetch its URL for download confirmation. I attempted to monitor network activity, but the file appears to be served directly, without any network request. Additionally, I'm unable to access the download directory as this is set to run on CI.
I tried looking if puppeteer provides some way to confirm the download, but couldn't find any.
May you please share some approach to confirm the download of the revisions?

Thank you.

@Akhilesh-max I don't know offhand, but what online resources have you looked at for handling downloads in puppeteer? That's where I would start -- a quick search showed a bunch of results that might be promising and are probably worth investigating.

Also I think it's probably fine to make slight modifications to the flow for downloading these if needed, if it helps make things a bit easier on the acceptance tests side of things.

StephenYu2018

LGTM!

oppiabot · 2024-05-03T15:09:20Z

Assigning @nikitaevg, @U8NWXD for code owner reviews. Thanks!

nikitaevg

LGTM on the frontend changes

oppiabot · 2024-05-04T09:58:16Z

Unassigning @nikitaevg since they have already approved the PR.

oppiabot · 2024-05-04T19:35:32Z

Hi @Akhilesh-max, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

oppiabot · 2024-05-11T11:50:35Z

Hi @Akhilesh-max. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

oppiabot · 2024-05-18T12:30:42Z

Hi @Akhilesh-max, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

Akhilesh-max added 2 commits April 22, 2024 00:57

updates

d627d78

updates

41670b1

oppiabot bot assigned Akhilesh-max Apr 21, 2024

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label Apr 22, 2024

Akhilesh-max added 3 commits April 22, 2024 11:33

updates

355f265

updates

ef49dda

updates

360fb5d

oppiabot bot removed the PR: don't merge - HAS MERGE CONFLICTS label Apr 23, 2024

Akhilesh-max added 3 commits April 23, 2024 15:58

updates

041fcca

Merge branch 'develop' of https://github.com/oppia/oppia into oppia-11

f28d498

updates

f0c208a

Akhilesh-max marked this pull request as ready for review April 27, 2024 15:07

Akhilesh-max requested review from a team as code owners April 27, 2024 15:07

Akhilesh-max requested review from U8NWXD, StephenYu2018 and nikitaevg April 27, 2024 15:07

StephenYu2018 requested changes Apr 27, 2024

View reviewed changes

Akhilesh-max added 8 commits April 28, 2024 15:50

updates

b0766f1

updates

87ccdf8

Merge branch 'develop' of https://github.com/oppia/oppia into oppia-11

b67dce7

updates

7cfc590

updates

ecdecca

Merge branch 'develop' of https://github.com/oppia/oppia into oppia-11

4a07dd2

Merge branch 'develop' of https://github.com/oppia/oppia into oppia-11

7e3fdbd

updates

009db30

oppiabot bot unassigned Akhilesh-max May 1, 2024

Merge branch 'develop' into oppia-11

45bd820

StephenYu2018 requested changes May 1, 2024

View reviewed changes

core/tests/puppeteer-acceptance-tests/user-utilities/exploration-editor-utils.ts Outdated Show resolved Hide resolved

oppiabot bot unassigned StephenYu2018 May 1, 2024

oppiabot bot assigned Akhilesh-max May 1, 2024

Akhilesh-max added 4 commits May 3, 2024 14:32

updates

923bec1

Merge branch 'develop' of https://github.com/oppia/oppia into oppia-11

2dca2ce

Merge branch 'oppia-11' of https://github.com/Akhilesh-max/oppia into…

dbdc627

… oppia-11

updates

aac824f

Akhilesh-max commented May 3, 2024

View reviewed changes

StephenYu2018 approved these changes May 3, 2024

View reviewed changes

oppiabot bot assigned nikitaevg and U8NWXD May 3, 2024

nikitaevg approved these changes May 4, 2024

View reviewed changes

oppiabot bot unassigned nikitaevg May 4, 2024

U8NWXD approved these changes May 4, 2024

View reviewed changes

U8NWXD removed their assignment May 4, 2024

oppiabot bot added the PR: LGTM label May 4, 2024

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label May 11, 2024

oppiabot bot added the stale label May 18, 2024

oppiabot bot closed this May 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements part of #17712 : Acceptance tests for CUJs in the history tab of the exploration creator. #20191

Implements part of #17712 : Acceptance tests for CUJs in the history tab of the exploration creator. #20191

Akhilesh-max commented Apr 21, 2024 •

edited

oppiabot bot commented Apr 21, 2024

oppiabot bot commented Apr 21, 2024

oppiabot bot commented Apr 22, 2024

StephenYu2018 left a comment

oppiabot bot commented May 1, 2024

StephenYu2018 left a comment

oppiabot bot commented May 1, 2024

oppiabot bot commented May 1, 2024

Akhilesh-max commented May 3, 2024

Akhilesh-max May 3, 2024

seanlip May 3, 2024 •

edited

seanlip May 3, 2024

StephenYu2018 left a comment

oppiabot bot commented May 3, 2024

nikitaevg left a comment

oppiabot bot commented May 4, 2024

oppiabot bot commented May 4, 2024

oppiabot bot commented May 11, 2024

oppiabot bot commented May 18, 2024

Implements part of #17712 : Acceptance tests for CUJs in the history tab of the exploration creator. #20191

Implements part of #17712 : Acceptance tests for CUJs in the history tab of the exploration creator. #20191

Conversation

Akhilesh-max commented Apr 21, 2024 • edited

Overview

Essential Checklist

PR Pointers

oppiabot bot commented Apr 21, 2024

oppiabot bot commented Apr 21, 2024

oppiabot bot commented Apr 22, 2024

StephenYu2018 left a comment

Choose a reason for hiding this comment

oppiabot bot commented May 1, 2024

StephenYu2018 left a comment

Choose a reason for hiding this comment

oppiabot bot commented May 1, 2024

oppiabot bot commented May 1, 2024

Akhilesh-max commented May 3, 2024

Akhilesh-max May 3, 2024

Choose a reason for hiding this comment

seanlip May 3, 2024 • edited

Choose a reason for hiding this comment

seanlip May 3, 2024

Choose a reason for hiding this comment

StephenYu2018 left a comment

Choose a reason for hiding this comment

oppiabot bot commented May 3, 2024

nikitaevg left a comment

Choose a reason for hiding this comment

oppiabot bot commented May 4, 2024

oppiabot bot commented May 4, 2024

oppiabot bot commented May 11, 2024

oppiabot bot commented May 18, 2024

Akhilesh-max commented Apr 21, 2024 •

edited

seanlip May 3, 2024 •

edited